-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Maps] Move sort out of top hits configuration #47279
Comments
Pinging @elastic/kibana-gis (Team:Geo) |
Sounds reasonable. How else would a general sorting parameter affect the map results, outside of the "top hits" option?
I'd also like us to be mindful of not giving the user too many choices up front. But that also can be solved more generally by moving some options to Advanced (for example) in the future. |
I think we already do a good job of this. When you create a layer, the only options are index pattern and geo field. All of these other options are only visible when editing a layer so users get to see dots a on a a map before getting presented with too many inputs |
@nreese is my assumption about the sorting affecting visual ordering accurate? |
yes, the items are visualized in the order they are returned |
Closed by #47361 |
#46882 requests for sorting top hits by number fields instead of time fields. As I started to look into the implementation it occurred to me, "Hey, why do we bury sort input under top hits? Won't users want to sort regular searches as well"
Implementing #46882 will require a saved object migration because the sort state is stored in a field called
topHitsTimeField
. That name is not generic enough to support numbers. As long as I have to change the name, why not just change it tosortField
and move the sort UI out of top hits and let users to sort all Elasticsearch documents, not just those with top hits?Thoughts?
The text was updated successfully, but these errors were encountered: