Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove use_field_mapping format on 7.x versions #47727

Closed
markov00 opened this issue Oct 9, 2019 · 7 comments · Fixed by #71168
Closed

Remove use_field_mapping format on 7.x versions #47727

markov00 opened this issue Oct 9, 2019 · 7 comments · Fixed by #71168
Assignees
Labels
bug Fixes for quality problems that affect the customer experience chore Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort

Comments

@markov00
Copy link
Member

markov00 commented Oct 9, 2019

Kibana version:
7.x

Describe the bug:

When using a Metric visualization with a Top Hits metric, ES will log the following warning:

{"level": "WARN", "component": "o.e.d.s.f.s.DocValueFieldsFetchSubPhase",  "message": "[use_field_mapping] is a special format that was only used to ease the transition to 7.x. It has become the default and shouldn't be set explicitly anymore."  }

Steps to reproduce:

  1. Create a Metric Visualization
  2. Specify a Top Hits as metric aggregation
  3. Choose a field different from timestamp
  4. See the warning logged in the ES logs

Expected behavior:

No warning should be logged

Screenshots (if relevant):
n/a

Errors in browser console (if relevant):
n/a

@markov00 markov00 added chore Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) Feature:MetricVis Metric visualization feature Team:Visualizations Visualization editors, elastic-charts and infrastructure :KibanaApp/fix-it-week labels Oct 9, 2019
@markov00 markov00 self-assigned this Oct 9, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@nyetwurk
Copy link

Please make sure that if you fix this it retroactively applies to existing visualizations.

@markov00 markov00 removed their assignment May 26, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@timroes timroes removed :KibanaApp/fix-it-week Feature:MetricVis Metric visualization feature Team:Visualizations Visualization editors, elastic-charts and infrastructure labels May 26, 2020
@timroes
Copy link
Contributor

timroes commented May 26, 2020

Removing this from App list, since this is a pure thing inside the top_hits AggType not related to the metrics visualization specifically. So App Arch responsibility.

@lukeelmers lukeelmers self-assigned this May 27, 2020
@lukeelmers lukeelmers added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels May 27, 2020
@lukeelmers
Copy link
Member

We should address #64734 at the same time as this issue

@lukeelmers
Copy link
Member

Fixing this will also likely address #68883

@lukeelmers lukeelmers added impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. and removed impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. labels Jun 11, 2020
@lukeelmers lukeelmers added triaged bug Fixes for quality problems that affect the customer experience labels Jul 2, 2020
@lukeelmers
Copy link
Member

I've opened a PR to address this. At the moment the plan is to have it backported for 7.9

Please make sure that if you fix this it retroactively applies to existing visualizations.

This should not be a concern as the use_field_mapping param was never stored in visualization saved objects and was only ever added on-the-fly. So once this fix is released it should remove the deprecation warning for any visualizations using a top hits aggregation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience chore Feature:Aggregations Aggregation infrastructure (AggConfig, esaggs, ...) impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants