Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove temporary src/plugins/eui_utils eslint overrides #49555

Closed
spalger opened this issue Oct 28, 2019 · 4 comments · Fixed by #52782
Closed

Remove temporary src/plugins/eui_utils eslint overrides #49555

spalger opened this issue Oct 28, 2019 · 4 comments · Fixed by #52782
Labels
chore Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.

Comments

@spalger
Copy link
Contributor

spalger commented Oct 28, 2019

In order to move forward with #49244 we needed to disable some rules in src/plugins/eui_utils. We need to remove the related overrides and get the package passing these rules pretty soon.

// .eslintrc.js
{
  files: ['src/plugins/eui_utils/**/*.{js,ts,tsx}'],
  rules: {
    'react-hooks/exhaustive-deps': 'off',
  },
},
@spalger spalger added the chore label Oct 28, 2019
@timroes timroes added the Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. label Nov 18, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-design (Team:Design)

@cchaos
Copy link
Contributor

cchaos commented Dec 11, 2019

@spalger Where are you seeing these rules in eui_utils?

@spalger
Copy link
Contributor Author

spalger commented Dec 11, 2019

@cchaos when I disable the overrides in the root .eslintrc.js I see

image

@cchaos
Copy link
Contributor

cchaos commented Dec 11, 2019

Ok so you're talking about the last line of

useEffect(() => {
const s = getChartsTheme$().subscribe(update);
return () => s.unsubscribe();
}, [false]);

I hadn't written that part of the plugin and not really sure what it does. You are welcome to change whatever needs to change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants