Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ML] Remove temporary x-pack/legacy/plugins/ml eslint overrides #49565

Closed
spalger opened this issue Oct 28, 2019 · 3 comments · Fixed by #139907
Closed

[ML] Remove temporary x-pack/legacy/plugins/ml eslint overrides #49565

spalger opened this issue Oct 28, 2019 · 3 comments · Fixed by #139907
Assignees

Comments

@spalger
Copy link
Contributor

spalger commented Oct 28, 2019

In order to move forward with #49244 we needed to disable some rules in x-pack/legacy/plugins/ml. We need to remove the related overrides and get the package passing these rules pretty soon.

// .eslintrc.js
{
  files: ['x-pack/legacy/plugins/ml/**/*.{js,ts,tsx}'],
  rules: {
    'react-hooks/exhaustive-deps': 'off',
    'react-hooks/rules-of-hooks': 'off',
    'jsx-a11y/click-events-have-key-events': 'off',
  },
},
@elasticmachine
Copy link
Contributor

Pinging @elastic/ml-ui (:ml)

@peteharverson peteharverson changed the title Remove temporary x-pack/legacy/plugins/ml eslint overrides [ML] Remove temporary x-pack/legacy/plugins/ml eslint overrides Jan 7, 2020
@spalger
Copy link
Contributor Author

spalger commented Sep 6, 2022

@jgowdyelastic saw #139907, but are the rest of these temporary overrides still in place or can we close this?

@jgowdyelastic
Copy link
Member

Looks like this can be closed. There are no overrides for ml in .eslintrc.js anymore.
We are suppressing quite a few exhaustive-deps errors in the code, which we'll work our way through fixing.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants