Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Alerts client returns mixed TypeScript types #49703

Closed
mikecote opened this issue Oct 30, 2019 · 1 comment · Fixed by #53821
Closed

Alerts client returns mixed TypeScript types #49703

mikecote opened this issue Oct 30, 2019 · 1 comment · Fixed by #53821
Assignees
@gmmorris
Labels
bug Fixes for quality problems that affect the customer experience Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@mikecote
Copy link
Contributor

It was found that alertsClient.get(...) returns mixed types. It should return a consistent type. This is caused by the getAlertFromRaw function that returns two different structures depending if the alert has actions or not.
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-stack-services (Team:Stack Services)

@bmcconaghy bmcconaghy added Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) and removed Team:Stack Services labels Dec 12, 2019
@mikecote mikecote added the bug Fixes for quality problems that affect the customer experience label Dec 13, 2019
@gmmorris gmmorris self-assigned this Dec 27, 2019
@gmmorris gmmorris mentioned this issue Dec 27, 2019
Merged
7 tasks
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@gmmorris gmmorris

Labels
bug Fixes for quality problems that affect the customer experience Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

adds strict types to Alerting Client gmmorris/kibana
5 participants
@gmmorris @kobelb @bmcconaghy @mikecote @elasticmachine