Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Uptime] Chart Wrapper missing unit tests #50364

Closed
shahzad31 opened this issue Nov 12, 2019 · 1 comment · Fixed by #50399
Closed

[Uptime] Chart Wrapper missing unit tests #50364

shahzad31 opened this issue Nov 12, 2019 · 1 comment · Fixed by #50399
Assignees
@shahzad31
Labels
Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability test-unit

Comments

@shahzad31
Copy link
Contributor

Describe the feature:
Chart wrapper was added to add loading state to charts as well as to handle responsive use cases.
Describe a specific use case for the feature:
Some unit test should be added to the component to improve coverage.
@shahzad31 shahzad31 self-assigned this Nov 12, 2019
@shahzad31 shahzad31 mentioned this issue Nov 12, 2019
Merged
@azasypkin azasypkin added Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability test-unit labels Nov 13, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/uptime (Team:uptime)

@zube zube bot reopened this Nov 22, 2019
@zube zube bot closed this as completed Nov 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shahzad31 shahzad31

Labels
Team:Uptime - DEPRECATED Synthetics & RUM sub-team of Application Observability test-unit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Uptime] added test for chart wrapper shahzad31/kibana
4 participants
@andrewvc @azasypkin @shahzad31 @elasticmachine