Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

User is able to navigate to next page in wizard for new policy with no repository/name/snapshot name configured #51397

Closed
cuff-links opened this issue Nov 21, 2019 · 5 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@cuff-links
Copy link
Contributor

cuff-links commented Nov 21, 2019

Environment

Kibana: 7.5.0 BC7
Elasticsearch 7.5.0 BC7
Browsers: All Browsers

This issue is a continuation from the state you are in on a previous issue. From where you leave off in that issue, you can continue with the following steps.

Steps to reproduce:
1.) Click the Create a Policy button
2.) Don't add any information.
3.) Take note of the error telling you that you don't have any repositories.

Screen Shot 2019-11-21 at 6 02 14 PM

4.) Ignore the message and click next.

Expected Result:
You should either get an error or be forced to go create a repository. You should also be forced to add a policy name and snapshot name before being able to continue to the next step.

Actual Result:
You are able to go to the next step and all subsequent steps until the review. Once you try to hit submit on the review, then you get an error that you can't create the policy.

Screen Shot 2019-11-21 at 6 04 17 PM

@cuff-links cuff-links added the Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more label Nov 21, 2019
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@cuff-links cuff-links added bug Fixes for quality problems that affect the customer experience Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI labels Nov 21, 2019
@cuff-links cuff-links changed the title User is able to navigate to next page in wizard for new policy with no repository configured User is able to navigate to next page in wizard for new policy with no repository/name/snapshot name configured Nov 21, 2019
@jkelastic jkelastic self-assigned this Jan 18, 2020
@alisonelizabeth
Copy link
Contributor

alisonelizabeth commented Jan 30, 2020

@cuff-links is this more in line with what you would expect? I moved the callout message to the top of the page and disabled the "Next" button.

Screen Shot 2020-01-30 at 3 39 52 PM

We should also probably take a similar approach if there is an error loading repositories, as the user would not be able to successfully create a policy if the repository dropdown is not populated. Note that #56442 will likely need to be addressed first for this.

/cc @jkelastic

@alisonelizabeth
Copy link
Contributor

Hi @jkelastic! Are you still actively working this issue? If not, can you remove yourself as assignee?

@jkelastic
Copy link
Contributor

@alisonelizabeth No problem, I will remove myself. Thanks.

@jkelastic jkelastic removed their assignment Apr 19, 2021
@alisonelizabeth
Copy link
Contributor

I think this issue is low impact as we do display an error message, just not at the first step. Closing as not planned for now.

@alisonelizabeth alisonelizabeth closed this as not planned Won't fix, can't repro, duplicate, stale Sep 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Snapshot and Restore Elasticsearch snapshots and repositories UI Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

No branches or pull requests

4 participants