Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Reporting] Schedule Reports with Task Manager #53900

Closed
tsullivan opened this issue Jan 2, 2020 · 8 comments
Closed

[Reporting] Schedule Reports with Task Manager #53900

tsullivan opened this issue Jan 2, 2020 · 8 comments
Assignees
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead enhancement New value added to drive a business result Feature:Reporting:Framework Reporting issues pertaining to the overall framework impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort needs-team Issues missing a team label

Comments

@tsullivan
Copy link
Member

Stakeholder teams in bold

  1. Remove ESQueue from the Reporting libs [Reporting]
  2. Create TM tasks for the various kinds of scheduled reports, (starting with Canvas PDF) [Reporting]
  3. The Reporting screenshot observable needs to be in scope of the task, have an easy interface to run a job, and get run when the task fires [Reporting]
  4. Add UI controls to the visualization container to schedule regular reports [App Teams]

Making the screenshot observable more visible should have side benefits of improving testability.

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-reporting-services (Team:Reporting Services)

@kobelb
Copy link
Contributor

kobelb commented Jun 9, 2020

@elastic/kibana-alerting-services Does the task manager have any type of "per task type" concurrency control? We've been focusing on making task-manager capable of being more concurrent to support Alerting's needs, but if we spawn multiple Reporting jobs per instance of Kibana, we're likely to run out of memory.

@mikecote
Copy link
Contributor

mikecote commented Jun 9, 2020

@kobelb Not at this time. There was a way around this with numWorker until it got removed in #45504. It was possible to set numWorker on a task definition to equal the number of max workers and would ensure the task only runs while nothing else is running.

We have an issue for alerting / task manager to properly limit concurrency (#54916) but no efforts started yet.

@tsullivan
Copy link
Member Author

In ESQueue currently, we avoid claiming more than 1 job at a time, and I think we hold off on polling for new jobs while a current job is executing. We might need to find a way to retain that kind of behavior by handling for it in our task run function.

The plan is for Reporting to register only 1 task for all of its reporting needs.

@mikecote
Copy link
Contributor

I believe #54916 is the solution you're looking for. It would allow alerts to still run concurrently while a reporting task definition can limit to only one reporting task run at a time per Kibana instance.

Is such feature what you're looking for? If so, what release is scheduled reports targeting?

@alexfrancoeur
Copy link

alexfrancoeur commented Jun 11, 2020

I don't want to speak for @tsullivan and @joelgriffith but I was hoping we'd be able to deliver scheduled reports (on task manager, and simplified UI creation, management UI's) in 7.x 😄 . We haven't fully defined MVP yet though.

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServices)

@tsullivan tsullivan added (Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead and removed Team:Reporting Services labels Dec 17, 2020
@tsullivan tsullivan added Team:Reporting Services enhancement New value added to drive a business result and removed release_note:enhancement labels Feb 25, 2021
@tsullivan
Copy link
Member Author

Closed via #64853

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels May 13, 2021
@sophiec20 sophiec20 added Feature:Reporting:Framework Reporting issues pertaining to the overall framework and removed (Deprecated) Team:Reporting Services labels Aug 21, 2024
@botelastic botelastic bot added the needs-team Issues missing a team label label Aug 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
(Deprecated) Feature:Reporting Use Reporting:Screenshot, Reporting:CSV, or Reporting:Framework instead enhancement New value added to drive a business result Feature:Reporting:Framework Reporting issues pertaining to the overall framework impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort needs-team Issues missing a team label
Projects
None yet
Development

No branches or pull requests

8 participants