Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Support undo/redo #54971

Open
wylieconlon opened this issue Jan 15, 2020 · 2 comments
Open

[Lens] Support undo/redo #54971

wylieconlon opened this issue Jan 15, 2020 · 2 comments
Labels
Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@wylieconlon
Copy link
Contributor

There are various techniques that could be used to support undo/redo in Lens, but most will depend on a core restructing: #52792 One of the main features of the restructuring is to put all state into the top level, which would be useful for tracking undo/redo history.

Undo/redo systems can be tricky. Most Kibana apps sync their state to the URL, which gives a nice integration with the browser forward/back buttons. But Lens does not currently save its state to the URL, and the Lens state is a large object that should only get partially serialized.

The simplest undo/redo system for Lens would be to store the previous N state objects in their entirety. To "undo," we go back to the previous state. Every time the state changes, clear the "redo" list. This would be limited but effective.

@wylieconlon wylieconlon added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Jan 15, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@drewdaemon
Copy link
Contributor

Lens PoC: #157782

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. release_note:enhancement Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

6 participants