Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ApplicationService.currentAppId$ does not emit for legacy application #55444

Closed
pgayvallet opened this issue Jan 21, 2020 · 1 comment · Fixed by #55536
Closed

ApplicationService.currentAppId$ does not emit for legacy application #55444

pgayvallet opened this issue Jan 21, 2020 · 1 comment · Fixed by #55536
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@pgayvallet
Copy link
Contributor

pgayvallet commented Jan 21, 2020

The currentAppId$ is currently updated in the NP apps mount function

const mount: AppMounter = async params => {
const unmount = await handler(params);
this.currentAppId$.next(app.id);
return unmount;
};

  • It will never trigger for legacy apps that uses a page refresh to display
  • It seems like even for NP app, mount it's not called on initial display (need to confirm)

currentAppId$ should emit for the initially displayed app as soon as core got the information, either from the service itself or from the AppRouter.

@pgayvallet pgayvallet added bug Fixes for quality problems that affect the customer experience Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc Feature:New Platform labels Jan 21, 2020
@pgayvallet pgayvallet self-assigned this Jan 21, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@pgayvallet pgayvallet changed the title ApplicationService.currentAppId$ does not emit for initial application ApplicationService.currentAppId$ does not emit for legacy application Jan 22, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants