Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[alerting event log] add more tests for existing but unused code #55642

Closed
pmuellr opened this issue Jan 22, 2020 · 2 comments · Fixed by #63540
Closed

[alerting event log] add more tests for existing but unused code #55642

pmuellr opened this issue Jan 22, 2020 · 2 comments · Fixed by #63540
Assignees
Labels
Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)

Comments

@pmuellr
Copy link
Member

pmuellr commented Jan 22, 2020

The code in the event log that deals with writing to ES is currently shipping as disabled by default, and to get the plugin merged to master sooner, writing tests for that code was deferred.

Time to add it! This is primarily code in the https://github.com/elastic/kibana/tree/master/x-pack/plugins/event_log/server/es directory, and it needs both jest and functional tests.

@pmuellr pmuellr added Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) labels Jan 22, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@mikecote
Copy link
Contributor

Some unit tests were added with the migrations issue (#58010). This issue can focus on adding functional / integration tests for indexing into Elasticsearch.

@YulNaumenko YulNaumenko self-assigned this Mar 30, 2020
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams)
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants