Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Server side sortable table columns while in edit mode #55905

Closed
wylieconlon opened this issue Jan 24, 2020 · 4 comments
Closed

[Lens] Server side sortable table columns while in edit mode #55905

wylieconlon opened this issue Jan 24, 2020 · 4 comments
Labels
enhancement New value added to drive a business result Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@wylieconlon
Copy link
Contributor

wylieconlon commented Jan 24, 2020

User goal: It should be possible for users to trigger server-side sorting from the Lens editor in at least some cases.

Technical background: The Lens architecture does not currently support this kind of sorting for several reasons, but primarily because of the separation between data sources and visualizations. Also, Elasticsearch doesn't support every kind of sorting, and this might need to be represented in our datasources.

As it exists today, the only sortable operation in Lens is the Terms aggregation, which can be sorted:

  • In up or down order by referencing another metric in Lens, such as Count or Sum.
    • Sorting in ascending order is not recommended, but we currently allow it.
  • Alphabetically up or down
  • (Not implemented) Using the default sort order, count

For the data table visualization to know that these limitations exist, we would need these architectural changes, provided via the getOperation function on data sources.

  • Operations need to indicate whether they are currently sorted, and if are capable of being sorted
  • If they are capable of being sorted, datasources need to handle the sorting interaction
  • References probably need to be provided to sort columns
@wylieconlon wylieconlon added Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jan 24, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@timroes timroes mentioned this issue Mar 31, 2020
29 tasks
@wylieconlon wylieconlon changed the title [Lens] Add column sorting to datatable plugin [Lens] Sortable table columns while in edit mode Mar 31, 2020
@flash1293 flash1293 added the enhancement New value added to drive a business result label Aug 6, 2020
@flash1293 flash1293 changed the title [Lens] Sortable table columns while in edit mode [Lens] Server side sortable table columns while in edit mode Sep 8, 2020
@flash1293
Copy link
Contributor

We decided to implement client side sorting during the "Lens by default" time frame - this is tracked here: #76962

@wylieconlon
Copy link
Contributor Author

Because the Terms aggregation is the biggest cause of confusion in sorting, I think we might want to push for the ability to do multi-field terms aggs, which I've written up here: #77632

@stratoula stratoula added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Jun 2, 2023
@stratoula
Copy link
Contributor

Thank you for contributing to this issue, however, we are closing this issue due to inactivity as part of a backlog grooming effort. If you believe this feature/bug should still be considered, please reopen with a comment.

@stratoula stratoula closed this as not planned Won't fix, can't repro, duplicate, stale Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants