Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Console error seen when you try to edit the fiter to change the ES query DSL #56424

Closed
rashmivkulkarni opened this issue Jan 30, 2020 · 7 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Filters good first issue low hanging fruit

Comments

@rashmivkulkarni
Copy link
Contributor

Stack : BC4 deployed on cloud AWS.

I was about to edit the DSL query in the filter I had pinned, I see the following error in the console . However, it allows to edit the query and save it as well.

kbn-ui-shared-deps.js:338 Uncaught Error: couldn't load module ace/theme/ or it didn't call define
    at a (kbn-ui-shared-deps.js:338)
    at kbn-ui-shared-deps.js:338
    at Array.forEach (<anonymous>)
    at kbn-ui-shared-deps.js:338
    at r (kbn-ui-shared-deps.js:338)
    at kbn-ui-shared-deps.js:338
    at l (kbn-ui-shared-deps.js:338)
    at HTMLScriptElement.r.onload.r.onreadystatechange (kbn-ui-shared-deps.js:338)
a @ kbn-ui-shared-deps.js:338
(anonymous) @ kbn-ui-shared-deps.js:338
(anonymous) @ kbn-ui-shared-deps.js:338
r @ kbn-ui-shared-deps.js:338
(anonymous) @ kbn-ui-shared-deps.js:338
l @ kbn-ui-shared-deps.js:338
r.onload.r.onreadystatechange @ kbn-ui-shared-deps.js:338
load (async)
ace.define.t.loadScript @ kbn-ui-shared-deps.js:338
ace.define.t.loadModule @ kbn-ui-shared-deps.js:338
ace.define.setTheme @ kbn-ui-shared-deps.js:338
setTheme @ kbn-ui-shared-deps.js:338
t.componentDidMount @ kbn-ui-shared-deps.js:433
ys @ kbn-ui-shared-deps.js:400
t.unstable_runWithPriority @ kbn-ui-shared-deps.js:408
Ur @ kbn-ui-shared-deps.js:400
bs @ kbn-ui-shared-deps.js:400
is @ kbn-ui-shared-deps.js:400
(anonymous) @ kbn-ui-shared-deps.js:400
t.unstable_runWithPriority @ kbn-ui-shared-deps.js:408
Ur @ kbn-ui-shared-deps.js:400
Xr @ kbn-ui-shared-deps.js:400
Yr @ kbn-ui-shared-deps.js:400
le @ kbn-ui-shared-deps.js:400
En @ kbn-ui-shared-deps.js:400

Screen Shot 2020-01-30 at 11 03 50 AM

@rashmivkulkarni rashmivkulkarni added bug Fixes for quality problems that affect the customer experience Feature:Filters Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Jan 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@timroes
Copy link
Contributor

timroes commented Feb 6, 2020

cc @flash1293 could you check if that's a fallout of any of the Kibana Platform migrations?

@flash1293
Copy link
Contributor

Seems like this is a duplicate of #49964 - if it was in 7.5 it's unlikely that this is a fallout of our migration efforts. We should probably be able to fix this the same way like here: https://github.com/elastic/kibana/pull/50473/files . @timroes wdyt about a fix it week label on that one?

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@alexwizp
Copy link
Contributor

@flash1293 issues have been fixed on the Elastic UI side. After updating @elastic/ui lib this problem will be solved in all places in Kibana where we use CodeEditor

@flash1293
Copy link
Contributor

@alexwizp Does that mean we can remove the import 'brace/theme/github' calls we have in a few places or is that unrelated?

@alexwizp
Copy link
Contributor

@flash1293 yes, for places where we don't use 'github' theme! It's a good point, I'll check it across all Kibana when we receive new version of Elastic UI. Please don't close that issue.

@alexwizp alexwizp closed this as completed Jun 4, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Filters good first issue low hanging fruit
Projects
None yet
Development

No branches or pull requests

6 participants