Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should we rename lastScheduledActions? #57173

Closed
gmmorris opened this issue Feb 9, 2020 · 4 comments
Closed

Should we rename lastScheduledActions? #57173

gmmorris opened this issue Feb 9, 2020 · 4 comments
Labels
discuss estimate:small Small Estimated Level of Effort Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) technical debt Improvement of the software architecture and operational architecture

Comments

@gmmorris
Copy link
Contributor

gmmorris commented Feb 9, 2020

Follow up from PR comment: #56625 (comment)

@gmmorris gmmorris closed this as completed Feb 9, 2020
@gmmorris gmmorris reopened this Feb 9, 2020
@mshustov mshustov added the Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) label Feb 10, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-alerting-services (Team:Alerting Services)

@pmuellr
Copy link
Member

pmuellr commented Feb 10, 2020

I was looking at this again on Friday, and realized it does, kinda make sense. You can have multiple actions associated with an alert group, so it's not lying. It seems like the name should be lastScheduledActionGroups though.

const metaSchema = t.partial({
lastScheduledActions: t.type({
group: t.string,
date: DateFromString,
}),
});

@mikecote
Copy link
Contributor

It seems like the name should be lastScheduledActionGroups though.

Plural seems a bit weird as there can only be one group that can have last schedule actions (fire) for.

@gmmorris gmmorris added the Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework label Jul 1, 2021
@gmmorris gmmorris added the loe:medium Medium Level of Effort label Jul 14, 2021
@gmmorris gmmorris added technical debt Improvement of the software architecture and operational architecture estimate:small Small Estimated Level of Effort labels Aug 16, 2021
@gmmorris gmmorris removed the loe:medium Medium Level of Effort label Sep 2, 2021
@kobelb kobelb added the needs-team Issues missing a team label label Jan 31, 2022
@botelastic botelastic bot removed the needs-team Issues missing a team label label Jan 31, 2022
@mikecote
Copy link
Contributor

Closing due to lack of activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss estimate:small Small Estimated Level of Effort Feature:Alerting/RulesFramework Issues related to the Alerting Rules Framework Feature:Alerting Team:ResponseOps Label for the ResponseOps team (formerly the Cases and Alerting teams) technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

No branches or pull requests

6 participants