Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing advanced setting discover:sort:defaultOrder #59182

Open
Tracked by #114353
myasonik opened this issue Mar 3, 2020 · 2 comments
Open
Tracked by #114353

Removing advanced setting discover:sort:defaultOrder #59182

myasonik opened this issue Mar 3, 2020 · 2 comments
Labels
blocked discuss Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Discover Discover Application Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)

Comments

@myasonik
Copy link
Contributor

myasonik commented Mar 3, 2020

As part of the ongoing work to upgrade Discover to use DataGrid, with the new UI's more explicit sorting, the advanced setting doesn't make as much sense to keep around as it used to.

How do people feel about deprecating this setting along with the current implementation of the Discover table?

Related Discover sorting discussion: #54362
@myasonik myasonik added discuss Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages labels Mar 3, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293
Copy link
Contributor

One use case that comes to mind is environments where executing a search request on discover is costly and takes > 10 seconds to complete.

I remember we added an advanced setting ( discover:searchOnPageLoad ) to not search directly when opening discover not long ago for that specific case.

If we take away a custom default sort order, you would have to wait for the first search request to complete before you are able to change the order to what you prefer anyway. Totally possible I’m some important context here.

@timroes timroes added Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph) and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 31, 2021
@shaunmcgough shaunmcgough mentioned this issue Oct 7, 2021
Closed
9 tasks
@kertal kertal added blocked impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Dec 5, 2022
@TinaHeiligers TinaHeiligers added the Feature:Data Views Data Views code and UI - index patterns before 8.0 label Dec 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked discuss Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Discover Discover Application Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Team:DataDiscovery Discover App Team (Document Explorer, Saved Search, Surrounding documents, Graph)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
6 participants
@kertal @timroes @flash1293 @myasonik @TinaHeiligers @elasticmachine