Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Optimize run-time behaviour of fields processing for index template generation #60489

Closed
skh opened this issue Mar 18, 2020 · 2 comments
Closed

[Fleet] Optimize run-time behaviour of fields processing for index template generation #60489

skh opened this issue Mar 18, 2020 · 2 comments
Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Team:Fleet Team label for Observability Data Collection Fleet team technical debt Improvement of the software architecture and operational architecture

Comments

@skh
Copy link
Contributor

skh commented Mar 18, 2020

Currently, everything called from processFields() in ingest_manager/server/services/epm/fields/field.ts has been naively implemented and may have performance issues with large inputs. As this function is called once for each fields.yml present in package datasets during package installation, this may slow down package installation in an unacceptable way.

This task is to review and check the runtime behaviour of processFields() and the functions it calls. One particular pain point is dedupFields(), which searches over a growing list of dedupedFields in a loop, but there may be more.

Also, add more unit tests where applicable.
@skh skh added the Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project label Mar 18, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Feature:EPM)

This was referenced Mar 18, 2020
Closed
Merged
@skh skh self-assigned this Mar 26, 2020
@jen-huang jen-huang added the Team:Fleet Team label for Observability Data Collection Fleet team label Mar 26, 2020
@skh skh removed their assignment Apr 9, 2020
@ph ph added the technical debt Improvement of the software architecture and operational architecture label May 25, 2020
@jen-huang jen-huang changed the title [EPM] Optimize run-time behaviour of fields processing for index template generation [Fleet] Optimize run-time behaviour of fields processing for index template generation Apr 29, 2021
@jlind23
Copy link
Contributor

jlind23 commented Apr 4, 2023

Closing as not relevant anymore. Feel free to reopen if needed

@jlind23 jlind23 closed this as not planned Won't fix, can't repro, duplicate, stale Apr 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Team:Fleet Team label for Observability Data Collection Fleet team technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ph @skh @jen-huang @elasticmachine @jlind23