Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[EPM] Unit-test mapping generation for index templates #60499

Closed
skh opened this issue Mar 18, 2020 · 2 comments
Closed

[EPM] Unit-test mapping generation for index templates #60499

skh opened this issue Mar 18, 2020 · 2 comments
Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Team:Fleet Team label for Observability Data Collection Fleet team tests_needed

Comments

@skh
Copy link
Contributor

skh commented Mar 18, 2020 •
edited
Loading

The changes in #60266 are not adequately unit-tested.

This task is to start adding unit tests for the generation of index template mappings for datatypes in generateMappings() in ingest_manager/server/services/epm/elasticsearch/template/template.ts that are not handled in other tasks. In particular, object and multi_fields handling have their own tasks and don't need to be unit-tested in this one.
@skh skh added the Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project label Mar 18, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Feature:EPM)

@skh skh mentioned this issue Mar 18, 2020
Merged
@jen-huang jen-huang added the Team:Fleet Team label for Observability Data Collection Fleet team label Mar 26, 2020
@ruflin ruflin assigned ruflin and unassigned ruflin Apr 2, 2020
@jen-huang
Copy link
Contributor

We've added a lot more tests here since.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Team:Fleet Team label for Observability Data Collection Fleet team tests_needed
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@ph @skh @ruflin @jen-huang @elasticmachine