Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove local application service #61308

Closed
flash1293 opened this issue Mar 25, 2020 · 1 comment · Fixed by #68284
Closed

Remove local application service #61308

flash1293 opened this issue Mar 25, 2020 · 1 comment · Fixed by #68284
Assignees
Labels
Feature:NP Migration Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

Follow up of #61304

Once the legacy kibana app is fully migrated (including management and all server side code), the "local application service" (src/legacy/core_plugins/kibana/public/local_application_service/local_application_service.ts) rendering new platform apps in the legacy platform is not necessary anymore and can be removed together with the legacy plugin definition.

However URLs pointing to the kibana app still have to be handled for BWC (e.g. app/kibana#/discover should be redirected to app/discover#/). To be able to do this, the kibana_legacy plugin should register a plugin with the kibana id to pick up these URLs. The implementation of this app can be very rudimentary as it just has to redirect to the new location (not necessary to load angular or anything else):

core.application.register({
  id: 'kibana',
  async mount() {
    const newUrl = lookupUrlRedirect(window.location.href);
    window.location.replace(newUrl);
    // TODO error handling
  }
});
@flash1293 flash1293 added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:NP Migration labels Mar 25, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:NP Migration Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants