Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPM] Update paths to new structure from package registry #61447

Closed
neptunian opened this issue Mar 26, 2020 · 3 comments
Closed

[EPM] Update paths to new structure from package registry #61447

neptunian opened this issue Mar 26, 2020 · 3 comments
Assignees
Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@neptunian
Copy link
Contributor

This PR, changes the path structure from {package}-{version} to {package}/{version}. There are some places in EPM that will need to be updated. Here are some but there are probably more:

https://github.com/elastic/kibana/blob/master/x-pack/plugins/ingest_manager/server/services/epm/registry/index.ts#L102
https://github.com/elastic/kibana/blob/master/x-pack/plugins/ingest_manager/server/services/epm/packages/assets.ts#L38

The task is to get EPM working locally with the local PR of the registry and publish the changes together.

@neptunian neptunian added the Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project label Mar 26, 2020
@neptunian neptunian self-assigned this Mar 26, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Feature:EPM)

@jen-huang
Copy link
Contributor

FYI, I recall concatenating package name+version for some EPM API calls in agent config UI. Not sure if we are also planning on changing EPM APIs to /name/version as part of this issue too?

@jen-huang jen-huang added the Team:Fleet Team label for Observability Data Collection Fleet team label Mar 26, 2020
@neptunian
Copy link
Contributor Author

@jen-huang Based on some conversation, we have decided not to, so the EPM api will not change.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

No branches or pull requests

3 participants