[Fleet] Run locally the package registry during api integration tests

[nchaulet]

We have some api integration tests that depends on reaching package registry (https://github.com/elastic/package-registry)

So some tests could fail because we are not able to reach the package manager, and we should not rely on external services during API integration tests.

As discussed offline it's possible to run the package manager during tests. The package manager is a go application stateless, no database are required, and a docker container is already available to run it.

cc @spalger @jonathan-buttner

[elasticmachine]

Pinging @elastic/ingest-management (Feature:EPM)

[jonathan-buttner]

So some tests could fail because we are not able to reach the package manager, and we should not rely on external services during API integration tests.

Just a note, we'll want to use a local registry for endpoint's functional tests too, not just API integration tests.

[skh]

@jonathan-buttner Could you point me at an example of such a functional test in/for the endpoint plugin?

[jonathan-buttner]

@jonathan-buttner Could you point me at an example of such a functional test in/for the endpoint plugin?

@skh
The endpoint functional tests are here:
https://github.com/elastic/kibana/blob/master/x-pack/test/functional_endpoint
https://github.com/elastic/kibana/tree/master/x-pack/test/functional_endpoint_ingest_failure

I'm not sure exactly how many of the functional_endpoint actually interact with the ingest manager directly but since endpoint relies on the ingest manager to get the ES index pattern for it's queries it's likely most of the tests.

This was the test suite that failed recently because of the package registry change: https://github.com/elastic/kibana/blob/master/x-pack/test/functional_endpoint/apps/endpoint/policy_list.ts#L16

This test checks to make sure the ingest manager initialized correctly (absence of a toast being displayed in the endpoint app): https://github.com/elastic/kibana/blob/master/x-pack/test/functional_endpoint/apps/endpoint/landing_page.ts#L26

It leverages this code: https://github.com/elastic/kibana/blob/master/x-pack/plugins/endpoint/public/applications/endpoint/view/setup.tsx#L42
Which uses ingest's contract here: https://github.com/elastic/kibana/blob/master/x-pack/plugins/ingest_manager/public/plugin.ts#L28

The endpoint enables ingest manager here: https://github.com/elastic/kibana/blob/master/x-pack/test/functional_endpoint/config.ts#L34

For references the endpoint API tests are here:
https://github.com/elastic/kibana/blob/master/x-pack/test/api_integration/apis/endpoint/index.ts#L17

And leverage a service to call the setup API in ingest: https://github.com/elastic/kibana/blob/master/x-pack/test/api_integration/services/ingest_manager.ts#L12

[jen-huang]

@nchaulet Could you double check the issues linked the PR (#66736) that closed this issue? I think it's unrelated so reopening this one.

[nchaulet]

@jen-huang You are right this is not fixed

[skh]

Implemented in #69822