Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fleet] Fix findAgentByAccessKeyId #61796

Closed
6 tasks done
nchaulet opened this issue Mar 30, 2020 · 1 comment · Fixed by #61816
Closed
6 tasks done

[Fleet] Fix findAgentByAccessKeyId #61796

nchaulet opened this issue Mar 30, 2020 · 1 comment · Fixed by #61816
Assignees
@nchaulet
Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Feature:Fleet Fleet team's agent central management project Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@nchaulet
Copy link
Member

nchaulet commented Mar 30, 2020 •
edited
Loading

Description

Related to #61552

We have a bug currently if the api key id start with - the search function is not returning the correct agent.

Todo

  • For access key
    • Escape correctly the api key id to be able to do the search
    • Validate we retrieve the good agent or throw
  • For enrollment key
    • Escape correctly the api key id to be able to do the search
    • Validate we retrieve the good enrollment key or throw

Add tests.
@nchaulet nchaulet added Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Feature:Fleet Fleet team's agent central management project labels Mar 30, 2020
@nchaulet nchaulet self-assigned this Mar 30, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Feature:EPM)

@nchaulet nchaulet mentioned this issue Mar 30, 2020
Merged
@nnamdifrankie nnamdifrankie mentioned this issue Apr 8, 2020
Closed
1 task
@jen-huang jen-huang added the Team:Fleet Team label for Observability Data Collection Fleet team label May 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nchaulet nchaulet

Labels
Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Feature:Fleet Fleet team's agent central management project Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Fleet] Fix find by apiKeyId escaping nchaulet/kibana
3 participants
@nchaulet @jen-huang @elasticmachine