Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[SPACES] default space should support /s/ api #62053

Closed
EthanStrider opened this issue Mar 31, 2020 · 2 comments · Fixed by #77109
Closed

[SPACES] default space should support /s/ api #62053

EthanStrider opened this issue Mar 31, 2020 · 2 comments · Fixed by #77109
Assignees
Labels
enhancement New value added to drive a business result Feature:Security/Spaces Platform Security - Spaces feature Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!

Comments

@EthanStrider
Copy link

Describe the feature:
The default space is the only space that does not use the /s/<name> api approach

Describe a specific use case for the feature:
I understand why the default space uses the api format that it does, but it would make more sense if the default space supported both api approaches. Being agnostic would mean that the defaultspace is not a special case when writing automation for spaces in general.

@EthanStrider EthanStrider added the Feature:Security/Spaces Platform Security - Spaces feature label Mar 31, 2020
@jportner jportner added the Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! label Mar 31, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-security (Team:Security)

@legrego
Copy link
Member

legrego commented Mar 31, 2020

For reference, I think the relevant code is here:

We will have to update this to distinguish between requests made to the default space implicitly (i.e., without the /s/default identifier), and those made explicitly (i.e., with the /s/default identifier). We will want to rerwrite the url within the default space only if they're explicitly specifying it via /s/default, and skip the rewrite otherwise.

I haven't done any analysis downstream of this interceptor, but this should at least give us a starting point

@legrego legrego added the enhancement New value added to drive a business result label Sep 17, 2020
@legrego legrego self-assigned this Oct 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Security/Spaces Platform Security - Spaces feature Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more!
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants