Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Should Lens use colors from shared color service? #62193

Closed
wylieconlon opened this issue Apr 1, 2020 · 6 comments
Closed

[Lens] Should Lens use colors from shared color service? #62193

wylieconlon opened this issue Apr 1, 2020 · 6 comments
Labels
discuss Feature:Dashboard Dashboard related features Feature:Lens Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@wylieconlon
Copy link
Contributor

The color mapping service is used by multiple visualizations (but not Lens), so that when two visualizations are shown in a dashboard, they use the same color scheme. If there are any duplicate values in the visualizations, they get the same color. This works because there is a default Kibana palette which visualizations share today- but Lens doesn't use the default palette or the color service.

The benefit of using the color service in Lens would be that if multiple Lens visualizations are embedded in a dashboard, colors would be shared like other visualizations. However, there are some open questions about how this would work.

  • Can we have a dashboard legend instead of a chart-level legend?
  • Should each Lens visualization have a theme input which can be passed in from the dashboard?
  • If themes are passed in from the dashboard, does it make sense to have the Lens editor support styling options at all?
  • Does Lens use the right default today? I find that our default colors are too noisy for most use cases.
  • We want to support color palettes in Lens as well as in Kibana as a whole. If we implement it first in Lens, will that prevent us from making a wider change in Kibana?

This issue is intended to discuss how Lens will use colors, which is related to many other issues:

@wylieconlon wylieconlon added discuss Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Feature:Dashboard Dashboard related features Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Apr 1, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-design (Team:Design)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@cchaos
Copy link
Contributor

cchaos commented Apr 1, 2020

To clarify are you talking strictly about just the color palette values or how they're mapped to indice field values?

@wylieconlon
Copy link
Contributor Author

@cchaos the color mapping service that we have today does both of those things. To list what it does more explicitly:

  • The color service provides a base palette of 7 colors
  • The color service provides a way of extending the palette using hue shifting
  • The color service gives each unique name a unique color
  • The color service also makes sure that when you see the same value in multiple charts, each chart displays the same color. For example, if "OS X" is blue in one chart, it's blue in every chart.
  • Because the color service is used for dashboards in general, the colors used in any specific visualization are only a subset of the overall colors- this can look weird

Given that this is how it works today, would we want to use this approach in Lens? If not, which parts of the service would we want to change?

@wylieconlon
Copy link
Contributor Author

TSVB is also not using the color service: this issue I opened highlights the issue that Lens has as well, which is that it's doing a custom color scheme.

@timroes timroes added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 7, 2020
@wylieconlon
Copy link
Contributor Author

Closing as we have made a decision about this: #81976

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Feature:Dashboard Dashboard related features Feature:Lens Team:Platform-Design Team Label for Kibana Design Team. Support the Analyze group of plugins. Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Development

No branches or pull requests

4 participants