Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Maps] All ES layers break when a query for only one layer is not supported. #63388

Closed
thomasneirynck opened this issue Apr 13, 2020 · 6 comments
Labels
bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation triage_needed

Comments

@thomasneirynck
Copy link
Contributor

thomasneirynck commented Apr 13, 2020

Kibana version:

7.x and up

Describe the bug:

When a single SearchSource query fails in Maps, all layers break,.

Steps to reproduce:

  1. Ensure you have both an index_pattern with geo_point and geo_shape fields, but each with different names
    • sample datasets include geo_point index-patterns (use kibana_sample_logs)
    • if you don't have an index with geo_shape, you can use the GeoJson upload functionality in Maps
      • go to maps.elastic.co
      • press "Download GeoJson"
      • in Maps, go to "Add Layer" > "Import GeoJson" to upload the world.json file
  2. Add these index patterns to the Map
    • Click "Add layer"
    • Select "Documents"

The map will look something like:

image

  1. Add a bounds-filter on the points-layer
    • Click the wrench-icon
    • select "Draw bounds to filter data"
    • Select "kibana_sample_logs"
    • Draw the bounds -> This will add a bounds filter to the global filter bar

image

-> Note that both layers fail to fetch data with a vague error message ("Bad Request). This is because one of the sub-requests breaks.

image

The call to this endpoint http://localhost:5601/uoh/internal/search/es breaks. It shouldn't, as the query should still complete for the layers that do have a corresponding field.

Expected behavior:

Only the shape-layer breaks (due to not having a geo.coordinates field). The point layer should get filtered correctly.

@thomasneirynck thomasneirynck changed the title [Maps] When one query fails, all query fail [Maps] All ES layers break when a query for only one layer is not supported. Apr 13, 2020
@thomasneirynck thomasneirynck added bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Apr 13, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-gis (Team:Geo)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@ppisljar
Copy link
Member

ppisljar commented Jul 6, 2020

@thomasneirynck have you looked into this yet, is this something you can solve on your side or is it something you need our help with ?

@thomasneirynck
Copy link
Contributor Author

@ppisljar I need to revisit, plz stay tuned thx

@thomasneirynck
Copy link
Contributor Author

Tried this again and can no longer reproduce. The map behaves as expected. Using the example from the description, point-logs (because they have that geo.coordinates field will be filtered and the shape-countries will all be filtered out (because they do not have that geo.coordinates field.

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience [Deprecated-Use Team:Presentation]Team:Geo Former Team Label for Geo Team. Now use Team:Presentation triage_needed
Projects
None yet
Development

No branches or pull requests

4 participants