Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CCR] IE 11 auto-follow pattern table action not triggered #63441

Closed
sebelga opened this issue Apr 14, 2020 · 6 comments
Closed

[CCR] IE 11 auto-follow pattern table action not triggered #63441

sebelga opened this issue Apr 14, 2020 · 6 comments
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:CCR and Remote Clusters IE11 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more

Comments

@sebelga
Copy link
Contributor

sebelga commented Apr 14, 2020

The "Delete auto-follow pattern" table action does not work in IE 11.

Screenshot 2020-04-14 at 09 21 02

Steps to reproduce

  • Create an auto-follow pattern
  • In the table view, click on the "Delete auto-follow pattern" button

Expected behaviour: a modal to confirm deletion should appear

Current behaviour: the modal does not open (no error message in the console).

If we select the pattern in the table and go through the "Manage pattern" to delete it, the modal does appear and we can delete it.

EDIT: After some more testing on IE 11 and CCR, it seems that the same issue occurs in the Follower indices table. The first and last item ("pause..." and "unfollow...") of the actions in the table does not work.

Screenshot 2020-04-14 at 13 39 44

cc @elastic/eui-design Is this a known issue on IE?

@sebelga sebelga added bug Fixes for quality problems that affect the customer experience Feature:CCR and Remote Clusters IE11 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more labels Apr 14, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/es-ui (Team:Elasticsearch UI)

@cchaos
Copy link
Contributor

cchaos commented Apr 14, 2020

Without knowing the exact implementation, it's hard to tell if this stems from EUI or not. We don't currently have any known issues with EuiBasicTable actions and IE11. I would double-check what the implementation is doing inside the onClick handler.

@cjcenizal
Copy link
Contributor

@sebelga I wonder if this is at all related to #63361. We are implementing those two actions in a bit of a weird way, by rendering a <span onClick> inside of a <button>. It may be that IE11 is unhappy about that.

@sebelga
Copy link
Contributor Author

sebelga commented Apr 15, 2020

@cjcenizal It does seem super strange to have wrapped a <span> with an onClick. I definitely don't recall doing that. But maybe there was a good reason?
Is this a blocker for 7.7? I don't think so as there is a workaround.

@cjcenizal
Copy link
Contributor

But maybe there was a good reason?

There are more details in the issue, but the essence is that it's due to our use of an HOC to codify the UX running up against limitations to the way the render option works when defining table actions.

Is this a blocker for 7.7?

I agree with you, not a blocker.

@yuliacech
Copy link
Contributor

Fixed via #84433

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:CCR and Remote Clusters IE11 Team:Kibana Management Dev Tools, Index Management, Upgrade Assistant, ILM, Ingest Node Pipelines, and more
Projects
None yet
Development

No branches or pull requests

5 participants