Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Datepicker is not translated into specified language in kibana.yml #63742

Closed
bhavyarm opened this issue Apr 16, 2020 · 9 comments
Closed

Datepicker is not translated into specified language in kibana.yml #63742

bhavyarm opened this issue Apr 16, 2020 · 9 comments
Labels
bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Project:i18n Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@bhavyarm
Copy link
Contributor

bhavyarm commented Apr 16, 2020 •
edited by lukeelmers
Loading

Kibana version: 7.7.0 BC77/7.6.2

Elasticsearch version: 7.7.0 BC77/7.6.2

Server OS version: darwin_x86_64

Browser version: chrome latest

Browser OS version: OS X

Original install method (e.g. download page, yum, from source, etc.): from staging

Describe the bug:
Date picker is not translated after user configures kibana.yml
i18n.locale: "zh-CN"

https://user-images.githubusercontent.com/7074629/79492738-644e0480-7fee-11ea-9ad7-461ec30ef72a.png
@bhavyarm bhavyarm added bug Fixes for quality problems that affect the customer experience Team:Localization labels Apr 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-localization (Team:Localization)

@bhavyarm
Copy link
Contributor Author

bhavyarm commented Apr 16, 2020 •
edited
Loading

Old bug: #41822 for reference cc @Bamieh @LeeDr

@lukeelmers lukeelmers added Project:i18n Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Oct 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

@lukeelmers
Copy link
Member

@bhavyarm @Bamieh Is this still an issue?

@Bamieh
Copy link
Member

Bamieh commented Nov 2, 2021 •
edited
Loading

I've added tests to make sure we have full EUI i18n token coverage.

The top nav uses EuiSuperDatePicker

If any translations are still missing from the date picker it means they are missing from the EUI EuiSuperDatePicker component and we need to collaborate further to make sure they have test coverage around this in the eui package.

I believe this is safe to close for now 👍

@exalate-issue-sync exalate-issue-sync bot added impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort labels Nov 4, 2021
@mshustov
Copy link
Contributor

mshustov commented Nov 5, 2021

If any translations are still missing from the date picker it means they are missing from the EUI EuiSuperDatePicker component and we need to collaborate further to make sure they have test coverage around this in the eui package.

Do we have an appropriate issue in the EUI repo?

I believe this is safe to close for now 👍

Shouldn't we close it when the problem is fixed in the EUI?

@lukeelmers
Copy link
Member

Do we have an appropriate issue in the EUI repo?

++ @Bamieh Do you know if we have an EUI issue for this? I did some digging and didn't see one, but might've missed it.

@Bamieh Bamieh mentioned this issue Nov 22, 2021
Closed
2 tasks
@Bamieh
Copy link
Member

Bamieh commented Nov 22, 2021

I've opened a ticket in EUI (elastic/eui#5398) to make sure they have some tests to ensure they have i18n coverage from their side.

@lukeelmers
Copy link
Member

Closing, this has been resolved upstream in EUI, and is working for all languages except French (which will be working after the next extraction)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. loe:small Small Level of Effort Project:i18n Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@lukeelmers @mshustov @Bamieh @bhavyarm @elasticmachine