Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add unit tests for new nav #65369

Closed
2 of 5 tasks
ryankeairns opened this issue May 5, 2020 · 3 comments · Fixed by #66685
Closed
2 of 5 tasks

Add unit tests for new nav #65369

ryankeairns opened this issue May 5, 2020 · 3 comments · Fixed by #66685
Assignees
Labels
REASSIGN from Team:Core UI Deprecated label for old Core UI team

Comments

@ryankeairns
Copy link
Contributor

ryankeairns commented May 5, 2020

Relates to #64018

Rough plan:

@ryankeairns ryankeairns added the REASSIGN from Team:Core UI Deprecated label for old Core UI team label May 5, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core-ui (Team:Core UI)

@ryankeairns ryankeairns mentioned this issue May 5, 2020
30 tasks
@kobelb
Copy link
Contributor

kobelb commented May 6, 2020

The CollapsibleNav could also benefit from adding tests to ensure the clicks have their intended effect, and the interoperation with localStorage is behaving properly.

Outside of that, this is a super-nit and will go away in the near future, so I don't think it's absolutely necessary... The InternalChromeStart added a getNavType$ which currently doesn't have any coverage, but it's just passing through the UISettingsClient observable, so it's really a cosmetic.

@myasonik
Copy link
Contributor

myasonik commented May 7, 2020

Opened elastic/eui#3443 to hopefully fix the type issue at the source instead of in Kibana

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
REASSIGN from Team:Core UI Deprecated label for old Core UI team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants