You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In 7.7 we had a bit of a fiasco when we realized how large all of the bundles had grown all of the sudden, and we really want to make it easier to spot the changes which lead up to the bundle sizes increasing dramatically on a pr-by-pr basis.
To do this we want to start tracking high-level metrics in an external service like the following:
size of artifacts loaded on the home page
number of modules in each KP bundle
number of files in the distributables
size of distributables
Additionally, we want to automatically notify PR authors when their PR effects those metrics in a way that the PR author can act on.
At some point we would ideally require sign off when changes to the metrics are large enough, but we will probably need to collect data for a while before we add additional hurdles in front of contributors getting code into the repo.
@spalger Collect some test reports that detail what comments on PRs might look like once this is turned on
Put comments on PRs, probably by pulling them in via the Jenkins pipeline code
The initial version of this metrics reporting is already in the repo: create a CiStatsReporter and call reporter.metric() to record a metric for the current CI build. Calls to this method when the CiStatsReporter context is not available in the environment will be a noop.
Here is an example of what we track for each build:
Additionally, to make this data easier to run ad-hoc visualizations on in the kibana-stats cluster, we plan to create summary documents that combine the data from the build documents and all the metric documents that will be stored in the kibana-stats cluster.
The text was updated successfully, but these errors were encountered:
In 7.7 we had a bit of a fiasco when we realized how large all of the bundles had grown all of the sudden, and we really want to make it easier to spot the changes which lead up to the bundle sizes increasing dramatically on a pr-by-pr basis.
To do this we want to start tracking high-level metrics in an external service like the following:
Additionally, we want to automatically notify PR authors when their PR effects those metrics in a way that the PR author can act on.
At some point we would ideally require sign off when changes to the metrics are large enough, but we will probably need to collect data for a while before we add additional hurdles in front of contributors getting code into the repo.
Current tasks:
The initial version of this metrics reporting is already in the repo: create a
CiStatsReporter
and callreporter.metric()
to record a metric for the current CI build. Calls to this method when theCiStatsReporter
context is not available in the environment will be a noop.Here is an example of what we track for each build:
When a
metric()
call is executed the following is recorded as well:(we're planning to rename "name" to "group", and "subName" to "metricName")
The intention behind this design is to make it easy to produce a table like below that can be logged on a PR:
Additionally, to make this data easier to run ad-hoc visualizations on in the kibana-stats cluster, we plan to create summary documents that combine the data from the build documents and all the metric documents that will be stored in the kibana-stats cluster.
The text was updated successfully, but these errors were encountered: