-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Ingest Manager][EPM] Expose way(s) to get latest package #66777
Comments
Pinging @elastic/ingest-management (Team:Ingest Management) |
Hi All, |
@paul-tavares thanks for the context. For that case, I'd love Ingest Manager to expose a way to get/create those links. It already has those functions so I think it's just about exporting them. Or maybe adding a variant for latest version. I still think EPR should answer this question of latest available, though. |
Agreed @jfsiii that having a common lib/service to build the route/URLs would be an even better way to ensure we don't break should Ingest change the UI routes. 👍 And being that it seems the Kibana arch. allows for common libs/services to be imported by other plugins (as long as they are exported at the root of When we (endpoint) get around to implementing the pivot to Ingest for creating a datasource, I can pickup this item and implement the EPM API route to get a package latest info. - if not yet implemented by then. |
@paul-tavares what is the reason for not wanting to call the registry api to get the latest package? |
@neptunian Not sure that it would be a good idea to call the registry directly being that we're really only dependent on Ingest (EPM in this case). Also, we would need to get plugged into whatever mechanism is in place (Kibana configuration?) that provides the URL to the registry. All of this is already handled via EPM, thus If at all possible, I feel it would be best for us to not call an external service directly but rather interact with Kibana's EPM instead. |
@paul-tavares @neptunian Yes, EPM is considered the interface for the registry. The registry is publicly accessible but its contract (for now) is with EPM. Perhaps this will change as we expand what it means to host your own registry & packages but for now only EPM should interact with the registry. |
Makes sense. |
@neptunian I like the change split out the package name from the version in the API route 👍 😃 . |
@paul-tavares if you want a client-side link, EPM can give you a function which takes one or two params and returns the correct value. Let's try for this over calling sharing any knowledge of EPMs route format |
Sounds good @jfsiii . Perhaps we should also use the Ingest kibana/x-pack/plugins/siem/public/endpoint_policy/store/policy_list/services/ingest.ts Lines 16 to 19 in bcfc029
|
Endpoint needed this info but couldn't get it from EPM. EPM has a service method
kibana/x-pack/plugins/ingest_manager/server/services/epm/registry/index.ts
Line 44 in 74bf877
Should EPM add the route and/or function to the public contract?
The text was updated successfully, but these errors were encountered: