Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dashboard "snapshot share" is not sharing panel state in view mode #66875

Closed
flash1293 opened this issue May 18, 2020 · 1 comment · Fixed by #79837
Closed

Dashboard "snapshot share" is not sharing panel state in view mode #66875

flash1293 opened this issue May 18, 2020 · 1 comment · Fixed by #79837
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas

Comments

@flash1293
Copy link
Contributor

Kibana version: 7.7 - master

Describe the bug: #62415 removed the panel state from the URL when in "View" mode. This makes the behavior of the "Share" panel confusing for snapshot mode - in the tooltip it states:
Screenshot 2020-05-18 at 11 49 35

Steps to reproduce:

  1. Go to dashboard in view mode
  2. Copy the "snapshot" url
  3. Change the dashboard and save it
  4. Visit the copied snapshot URL
  5. Saved changes from 3. are visible

Expected behavior:

Changes from 3. should not affect the snapshot URL

Any additional context:
In edit mode everything behaves as expected. A possible fix for this would be to not just pass window.location.href into the share menu, but add the full state the URL first: https://github.com/flash1293/kibana/blob/2f75810f16980f8ddea2df07c3cb448ce5fce276/src/plugins/dashboard/public/application/dashboard_app_controller.tsx#L929
@flash1293 flash1293 added bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features regression Team:Visualizations Visualization editors, elastic-charts and infrastructure labels May 18, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293 flash1293 mentioned this issue Jul 14, 2020
Closed
@timroes timroes added Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 7, 2020
@Dosant Dosant mentioned this issue Oct 7, 2020
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Fixes for quality problems that affect the customer experience Feature:Dashboard Dashboard related features regression Team:Presentation Presentation Team for Dashboard, Input Controls, and Canvas
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix dashboard "snapshot share" is not sharing panel state in view mode Dosant/kibana
3 participants
@timroes @flash1293 @elasticmachine