Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate Status Page UI #67979

Closed
joshdover opened this issue Jun 2, 2020 · 4 comments · Fixed by #72017
Closed

Migrate Status Page UI #67979

joshdover opened this issue Jun 2, 2020 · 4 comments · Fixed by #72017
Assignees
Labels
Feature:Legacy Removal Issues related to removing legacy Kibana Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@joshdover
Copy link
Contributor

Related to #41983

We want to migrate the UI before the server-side in order to cut off legacy UI plugins sooner.

This UI should be migrated to the NP status_page plugin and can continue to use the legacy status API for the time being.

@joshdover joshdover added Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc labels Jun 2, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-platform (Team:Platform)

@joshdover joshdover added the Feature:Legacy Removal Issues related to removing legacy Kibana label Jun 2, 2020
@pgayvallet pgayvallet self-assigned this Jul 8, 2020
@joshdover
Copy link
Contributor Author

@pgayvallet I think it would make sense to move this UI into src/core/public/core_app since it really should not be a plugin anymore. It's absolutely part of Core and should always be present.

@pgayvallet
Copy link
Contributor

pgayvallet commented Jul 13, 2020

@joshdover Fine with that. I guess that means that the associated http API shall be moved to core too (when we'll do it)?

EDIT: that also means that we should get rid of src/plugins/status_page ? It's currently only used for

const isStatusPageAnonymous = core.injectedMetadata.getInjectedVar(
'isStatusPageAnonymous'
) as boolean;
if (isStatusPageAnonymous) {
core.http.anonymousPaths.register('/status');
}

@joshdover
Copy link
Contributor Author

@joshdover Fine with that. I guess that means that the associated http API shall be moved to core too (when we'll do it)?

EDIT: that also means that we should get rid of src/plugins/status_page ? It's currently only used for

Yes and yes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Legacy Removal Issues related to removing legacy Kibana Feature:New Platform Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants