Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kbn/optimizer] Only allow refs to bundles described in kibana.json #69458

Closed
spalger opened this issue Jun 17, 2020 · 1 comment · Fixed by #70911
Closed

[kbn/optimizer] Only allow refs to bundles described in kibana.json #69458

spalger opened this issue Jun 17, 2020 · 1 comment · Fixed by #70911
Assignees
Labels
Team:Operations Team label for Operations Team v7.9.0

Comments

@spalger
Copy link
Contributor

spalger commented Jun 17, 2020

With #68986 merged the optimizer is much faster because cross-plugin imports are now transformed into references to the bundles from other plugins at buildtime. This is functional, but causes implicit dependencies to be created between the bundles. This causes problems when users start disabling plugins as a disabled plugins bundle is not loaded into the browser, but if another plugin imported code from that plugin it needs to be loaded into the browser or else we get a runtime error about a missing bundle.

To fix this we will make the relationships between bundles more explicit by defining a set of requiredBundles in the kibana.json file. Any plugin id listed in the requiredBundles list will have its bundle loaded into the browser, but the plugin itself will still only be loaded when the plugin is enabled via config.

Example issue that would be solved by this: #69394

@spalger spalger added Team:Operations Team label for Operations Team v7.9.0 labels Jun 17, 2020
@spalger spalger self-assigned this Jun 17, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-operations (Team:Operations)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Operations Team label for Operations Team v7.9.0
Projects
None yet
2 participants