Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Allow custom labels via index pattern fields #69908

Closed
2 of 3 tasks
kertal opened this issue Jun 25, 2020 · 11 comments
Closed
2 of 3 tasks

[Discover] Allow custom labels via index pattern fields #69908

kertal opened this issue Jun 25, 2020 · 11 comments
Assignees
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@kertal
Copy link
Member

kertal commented Jun 25, 2020

This issue describes a way to allow the user to enter a custom label in the index pattern management, and its usage in Discover.

So the user could enter a custom label for a field in the index pattern management

category_-kibana_sample_data_ecommerce-_Elastic

Usage in Discover
Discover_-_Elastic
)

In a further step we could make this value customizable in Discover (would need much more UI adaptions), but this implementation would solve the basic problems with long filenames that cannot be customized. And it has the advantage, that it's done on a higher level, so there's no need to customize a field in every saved search.

Places not using displayName

This should track all places that are not using displayName right now to present a field name, and should do so instead:

Open questions

  • How will we handle this in KQL? KQL does not know about labels and most likely shouldn't since it's a query language and it need to know about the original field name. Maybe the autocomplete could still show a display name when one is present for helping the user?
@kertal kertal added the Feature:Discover Discover Application label Jun 25, 2020
@kertal kertal added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Jun 25, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@kertal
Copy link
Member Author

kertal commented Jun 25, 2020

FYI: @mattkime @AlonaNadler

@kertal kertal added the enhancement New value added to drive a business result label Jun 25, 2020
@AlonaNadler
Copy link

AlonaNadler commented Jun 25, 2020

Is there an approach to change column names in Discover per specific saved search and not globally?
I think what you have here is solving the problem globally which is fantastic but I remember had more challenges

@wylieconlon
Copy link
Contributor

wylieconlon commented Jun 25, 2020

Linking to the previous discussions: #1896 #15246 #47659

@kertal
Copy link
Member Author

kertal commented Jun 25, 2020

@AlonaNadler this approach would be the first step (no prerequisites for the implementation, and multiple plugins could benefit from it without much adaption, speaking of discover, only a few lines of code), the specific saved search would be a follow up (much more prerequisites), a good second step.

@AlonaNadler
Copy link

Got it, thanks @kertal that will give at least a workaround for these specific asks 👍

@kertal kertal changed the title [Discover][Discuss] Custom labels via index pattern fields [Discover] Custom labels via index pattern fields Jul 9, 2020
@kertal kertal changed the title [Discover] Custom labels via index pattern fields [Discover] Allow custom labels via index pattern fields Jul 9, 2020
@dbehnood
Copy link

This would be very handy for visualizations.

@DhananjayanD
Copy link

When can we expect this changes

@kennethlwk
Copy link

Hi,

When can we expect to get this feature?
And will this be release in one of the 7.X version?

/Kenneth

@kertal
Copy link
Member Author

kertal commented Nov 2, 2020

@kennethlwk we're working on it, you can track the progress here: #70039

@timroes
Copy link
Contributor

timroes commented Nov 23, 2020

Closed via #70039

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Discover Discover Application Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

8 participants