Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[EPM][Ingest Manager][Bug] Support package index_patterns #70864

Closed
jonathan-buttner opened this issue Jul 6, 2020 · 4 comments
Closed

[EPM][Ingest Manager][Bug] Support package index_patterns #70864

jonathan-buttner opened this issue Jul 6, 2020 · 4 comments
Labels
bug Fixes for quality problems that affect the customer experience Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@jonathan-buttner
Copy link
Contributor

The package registry no longer supports defining asset directories with a dash -. This PR: #70320 switched many of the dashes to underscores. It didn't switch the index-pattern kibana saved object type: https://github.com/elastic/kibana/blob/master/x-pack/plugins/ingest_manager/common/types/models/epm.ts#L30

I tried switching it locally but I believe it needs to be set to index-pattern when being used in the bulk savedobject request to save the asset: https://github.com/elastic/kibana/blob/master/x-pack/plugins/ingest_manager/server/services/epm/packages/get_objects.ts#L24 .

The easiest fix I can think of is checking in that function to see if the type is index_pattern and changing it to index-pattern. I'm not sure if this is going to mess with anything else though.

@jonathan-buttner jonathan-buttner added bug Fixes for quality problems that affect the customer experience Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Feature:Ingest Management Team:Fleet Team label for Observability Data Collection Fleet team labels Jul 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@ph
Copy link
Contributor

ph commented Aug 17, 2020

@jonathan-buttner What is the status of this bug ?

@ph
Copy link
Contributor

ph commented Aug 17, 2020

I will close this, we have another issue open in #71633

that also relate to installed index-patterns

@jonathan-buttner
Copy link
Contributor Author

Sounds good 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:EPM Fleet team's Elastic Package Manager (aka Integrations) project Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

No branches or pull requests

4 participants