Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Usage Collection] Ensure unique type in usage collectors #70940

Closed
afharo opened this issue Jul 7, 2020 · 2 comments · Fixed by #70946
Closed

[Usage Collection] Ensure unique type in usage collectors #70940

afharo opened this issue Jul 7, 2020 · 2 comments · Fixed by #70946
Assignees
@afharo
Labels
Feature:Telemetry Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc

Comments

@afharo
Copy link
Member

afharo commented Jul 7, 2020

At the moment, we maintain an array of usage collectors and don't check for the duplicity of the registered type so, when grouping their output under stack_stats.kibana.plugins[type], some usage collectors might overwrite others.

Let's change the logic to validate the registered collector is not overwriting others.
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-telemetry (Team:KibanaTelemetry)

@afharo afharo mentioned this issue Jul 7, 2020
Merged
3 tasks
@afharo afharo self-assigned this Jul 7, 2020
@lukeelmers lukeelmers added the Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc label Oct 1, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-core (Team:Core)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@afharo afharo

Labels
Feature:Telemetry Team:Core Core services & architecture: plugins, logging, config, saved objects, http, ES client, i18n, etc
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[Usage Collection] Ensure no type duplicates afharo/kibana
3 participants
@lukeelmers @afharo @elasticmachine