Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Include ML in base privileges #71422

Closed
legrego opened this issue Jul 13, 2020 · 2 comments · Fixed by #115444
Closed

Include ML in base privileges #71422

legrego opened this issue Jul 13, 2020 · 2 comments · Fixed by #115444
Assignees
Labels
blocker Breaking Change Feature:Security/Feature Controls Platform Security - Spaces & Role Mgmt feature controls Feature:Upgrade Assistant impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.0.0

Comments

@legrego
Copy link
Member

legrego commented Jul 13, 2020

The Machine Learning feature should be included as part of the base privileges for the 8.0 release.
This is considered a breaking change since it would grant considerable privileges to existing users, and this may not be desirable for certain installations.

Joe edit 8/17: also mention in Upgrade Assistant if some users did not have access to ML currently will now have access in 8.0.

@legrego legrego added Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! blocker Feature:Security/Feature Controls Platform Security - Spaces & Role Mgmt feature controls labels Jul 13, 2020
@legrego legrego added the v8.0.0 label Feb 10, 2021
@exalate-issue-sync exalate-issue-sync bot added impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort labels Aug 5, 2021
@jportner jportner self-assigned this Aug 18, 2021
@jportner
Copy link
Contributor

jportner commented Sep 8, 2021

As mentioned in the linked meta issue (#111160), we need to do separate things for 7.x and master:

  • 7.x branch: Ensure that the 8.0 upgrade assistant accurately reflects all of the deprecations

    • Each deprecation should be set at the appropriate level (critical if it blocks the upgrade, warning if not)
    • Each deprecation should correctly describe when the breaking change will take effect (8.0, or a future version)
    • The copy (text) should be reviewed with the docs team
    • Any automation to fix the problem (correctiveActions.api registered in the DeprecationsService) should be implemented and tested
  • master branch: Ensure that, for breaking changes that take effect in 8.0, all appropriate code is removed

We discussed this particular issue with Platform leadership, and decided that the upgrade assistant in 7.x should provide a warning for any custom roles that do not currently grant access to ML that will grant access to ML post-8.0.
This means any role that grants a base privilege (all or read).

We should just surface a warning, we do not need to add any automated remediation to change any roles.

@jportner jportner assigned watson and unassigned jportner Sep 8, 2021
@jportner
Copy link
Contributor

We should just surface a warning, we do not need to add any automated remediation to change any roles.

One additional point: ML is only available for Platinum+ licenses, so we should only surface this warning for clusters >= that license level.

@exalate-issue-sync exalate-issue-sync bot added loe:medium Medium Level of Effort and removed loe:small Small Level of Effort labels Oct 18, 2021
@legrego legrego assigned XavierM and unassigned watson Oct 21, 2021
@exalate-issue-sync exalate-issue-sync bot added loe:small Small Level of Effort and removed loe:medium Medium Level of Effort labels Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocker Breaking Change Feature:Security/Feature Controls Platform Security - Spaces & Role Mgmt feature controls Feature:Upgrade Assistant impact:critical This issue should be addressed immediately due to a critical level of impact on the product. loe:small Small Level of Effort Team:Security Team focused on: Auth, Users, Roles, Spaces, Audit Logging, and more! v8.0.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants