Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discover] Improve selection of very long index pattern names #72098

Closed
kertal opened this issue Jul 16, 2020 · 14 comments
Closed

[Discover] Improve selection of very long index pattern names #72098

kertal opened this issue Jul 16, 2020 · 14 comments
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@kertal
Copy link
Member

kertal commented Jul 16, 2020

Currently the maximum width of the popover containing the index pattern names is 320px. There are index patterns with longer names e.g. that contain remote clusters, where the names are truncated then and this can lead to difficulties in selecting the right index pattern, here's an example:

Bildschirmfoto 2020-07-16 um 18 19 19

Note: There's the same issue in Lens

@kertal kertal added Feature:Discover Discover Application enhancement New value added to drive a business result Feature:Lens labels Jul 16, 2020
@mshustov
Copy link
Contributor

Do we want to add a feature request:

We are looking for a page divider functionality where a user could move it slightly to the right (e.g. max 20% of the screen width).

Or it's better to create a separate issue?

@kertal
Copy link
Member Author

kertal commented Jul 16, 2020

the question is, what page divider do they mean? if it's scaling the sidebar, this will definitely happen in the future

@plaformsre
Copy link

Hi @kertal @restrry ,

Much appreciate raising this feature request. The 20% has been a proposal based on our experience with the length (ti would work for us, but maybe not for other users).

Many thanks,
Dejan

@kertal
Copy link
Member Author

kertal commented Jul 17, 2020

@mapdegree got it. thx for the feedback!

@wylieconlon wylieconlon added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Sep 15, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@plaformsre
Copy link

Not sure where in code this is but we found the 320px width of the Kibana drop down could be easily extended. I am surprised the value is absolute value of px vs proportion of the screen. Even with 320 pixels, it seems rather small.

@kertal
Copy link
Member Author

kertal commented Feb 24, 2021

@mapdegree I do agree that it should ideally should be adapted to the screen size!

@timroes timroes added Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 31, 2021
@ghudgins ghudgins added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Sep 14, 2021
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-vis-editors (Team:VisEditors)

@ghudgins
Copy link
Contributor

ghudgins commented Sep 14, 2021

similar to the problem/solution in #103701 ...we could try to move this logic up to EUI or to something that's re-usable for this case as well

should consider implementing a common component for both lens & discover

@ThomThomson
Copy link
Contributor

@ghudgins, a common component for an IndexPatternPicker would be extremely helpful!

The Controls project will need one as well, and I've been thinking about how to ensure that the behaviour is the same for controls as it is for Lens and Discover.

@flash1293
Copy link
Contributor

flash1293 commented Sep 14, 2021

Especially with upcoming data view related changes it would be nice to have a simple component to render instead of rebuilding. @mattkime do you think we could handle this in the similar way as the field editor popover?

The least we could do is to move a dumb component rendering it in a nice way into kibana_react.

@mattkime
Copy link
Contributor

do you think we could handle this in the similar way as the field editor popover?

Sure, in so far as we can find agreement on the design.

I just received a request to have a separate title for data views. Currently, the index pattern and the title are the same thing. I suspect that implementing a separate title for data views would be a smaller (or at very least similar) effort to creating the reusable component but it would also provide other benefits.

The main obstacle to implementing a proper title for data views is simply prioritization. It'll be addressed relatively quickly if there's sufficient demand.

@kertal kertal added Team:AppServicesUx and removed Team:DataDiscovery Discover, search (e.g. data plugin and KQL), data views, saved searches. For ES|QL, use Team:ES|QL. labels Aug 12, 2022
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-services (Team:AppServicesUx)

@kertal kertal removed the Feature:Discover Discover Application label Aug 12, 2022
@stratoula
Copy link
Contributor

stratoula commented Aug 12, 2022

This is related to this #133858
As Caroline mentions there are alternatives but everything comes with its price. We think that with the custom dataview names there is now a workaround that can def help improve this problem.

I am closing this in favor of the other, as now we have the same dataview picker component in Lens and Discover and it is part of the unified search project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests