-
Notifications
You must be signed in to change notification settings - Fork 8.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Discover] Improve selection of very long index pattern names #72098
Comments
Do we want to add a feature request:
Or it's better to create a separate issue? |
the question is, what page divider do they mean? if it's scaling the sidebar, this will definitely happen in the future |
Hi @kertal @restrry , Much appreciate raising this feature request. The 20% has been a proposal based on our experience with the length (ti would work for us, but maybe not for other users). Many thanks, |
@mapdegree got it. thx for the feedback! |
Pinging @elastic/kibana-app (Team:KibanaApp) |
Not sure where in code this is but we found the 320px width of the Kibana drop down could be easily extended. I am surprised the value is absolute value of px vs proportion of the screen. Even with 320 pixels, it seems rather small. |
@mapdegree I do agree that it should ideally should be adapted to the screen size! |
Pinging @elastic/kibana-vis-editors (Team:VisEditors) |
similar to the problem/solution in #103701 ...we could try to move this logic up to EUI or to something that's re-usable for this case as well should consider implementing a common component for both lens & discover |
@ghudgins, a common component for an The Controls project will need one as well, and I've been thinking about how to ensure that the behaviour is the same for controls as it is for Lens and Discover. |
Especially with upcoming data view related changes it would be nice to have a simple component to render instead of rebuilding. @mattkime do you think we could handle this in the similar way as the field editor popover? The least we could do is to move a dumb component rendering it in a nice way into |
Sure, in so far as we can find agreement on the design. I just received a request to have a separate title for data views. Currently, the index pattern and the title are the same thing. I suspect that implementing a separate title for data views would be a smaller (or at very least similar) effort to creating the reusable component but it would also provide other benefits. The main obstacle to implementing a proper title for data views is simply prioritization. It'll be addressed relatively quickly if there's sufficient demand. |
Pinging @elastic/kibana-app-services (Team:AppServicesUx) |
This is related to this #133858 I am closing this in favor of the other, as now we have the same dataview picker component in Lens and Discover and it is part of the unified search project. |
Currently the maximum width of the popover containing the index pattern names is 320px. There are index patterns with longer names e.g. that contain remote clusters, where the names are truncated then and this can lead to difficulties in selecting the right index pattern, here's an example:
Note: There's the same issue in Lens
The text was updated successfully, but these errors were encountered: