Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Manager] Migrate all API integration tests to use dockerized registry #72151

Closed
jen-huang opened this issue Jul 16, 2020 · 1 comment · Fixed by #72621
Closed

[Ingest Manager] Migrate all API integration tests to use dockerized registry #72151

jen-huang opened this issue Jul 16, 2020 · 1 comment · Fixed by #72621
Assignees
Labels
Team:Fleet Team label for Observability Data Collection Fleet team technical debt Improvement of the software architecture and operational architecture

Comments

@jen-huang
Copy link
Contributor

jen-huang commented Jul 16, 2020

Now that we have an API integration test folder setup that uses a dockerized registry (#69822), we should move our other tests to this folder so that they use the docker service: https://github.com/elastic/kibana/tree/master/x-pack/test/ingest_manager_api_integration

This will let us avoid test failures related to unreachable registry URL, such as: #68568 (comment).

A non-exhaustive list of the test needing migration:
https://github.com/elastic/kibana/tree/master/x-pack/test/api_integration/apis/fleet
https://github.com/elastic/kibana/tree/master/x-pack/test/api_integration/apis/ingest_manager

There is also a defunct integration test folder within the plugin directory that should assessed and removed/migrated:
https://github.com/elastic/kibana/tree/master/x-pack/plugins/ingest_manager/server/integration_tests

Bonus: add more coverage as part of this migration effort!!

@jen-huang jen-huang added technical debt Improvement of the software architecture and operational architecture Team:Fleet Team label for Observability Data Collection Fleet team labels Jul 16, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Fleet Team label for Observability Data Collection Fleet team technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants