Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

License link in "Your query is taking a while" popup is not working #72801

Closed
Dosant opened this issue Jul 22, 2020 · 4 comments · Fixed by #79045
Closed

License link in "Your query is taking a while" popup is not working #72801

Dosant opened this issue Jul 22, 2020 · 4 comments · Fixed by #79045
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:License Feature:Search Querying infrastructure in Kibana impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort PR sent v7.8.0

Comments

@Dosant
Copy link
Contributor

Dosant commented Jul 22, 2020

In OSS if query is taking a while we show this popup:

Screenshot 2020-07-21 at 16 57 44 (1)

The link "Go to license options" doesn't work:

Current behaviour:

In 7.9-BC2 it navigates to /app/management/stack/license_management which doesn't exist in OSS.
in 7.8 it navigates to home page.

Expected behaviour:

Navigates somewhere with info about license,

Most likely here: https://www.elastic.co/subscriptions (not sure)


Also would be nice if that button would be a link ( a[href]), so right click -> open in new tab works.

cc @lukasolson, @lizozom

@Dosant Dosant added bug Fixes for quality problems that affect the customer experience Feature:Search Querying infrastructure in Kibana Feature:License loe:small Small Level of Effort Team:AppArch impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. v7.8.0 labels Jul 22, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@cjcenizal
Copy link
Contributor

In 7.9-BC2 it navigates to /app/management/stack/license_management which doesn't exist in OSS.

Sounds like license_management needs to be an optional dependency of this plugin, so you can tweak the text/behavior of this toast depending on its availability.

in 7.8 it navigates to home page.

For whoever looks into this, please note that in 7.9 we changed the URL for License Management (#65796), so you'll need to be aware of that if backporting a fix from master to 7.8.

@lizozom lizozom self-assigned this Aug 24, 2020
@lizozom
Copy link
Contributor

lizozom commented Aug 24, 2020

The behavior of this feature is changing in 7.10. I will make sure to address this issue.

@lukasolson
Copy link
Member

Related: #75727

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:License Feature:Search Querying infrastructure in Kibana impact:high Addressing this issue will have a high level of impact on the quality/strength of our product. loe:small Small Level of Effort PR sent v7.8.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants