Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Manager] Reduce height of Agent configuration selection box #72865

Closed
mostlyjason opened this issue Jul 22, 2020 · 3 comments · Fixed by #73172
Closed

[Ingest Manager] Reduce height of Agent configuration selection box #72865

mostlyjason opened this issue Jul 22, 2020 · 3 comments · Fixed by #73172
Assignees
Labels
Team:Fleet Team label for Observability Data Collection Fleet team

Comments

@mostlyjason
Copy link
Contributor

mostlyjason commented Jul 22, 2020

We've gotten feedback from several people including Ron, Ruflin and Shay that the Agent configuration selection box on the integration configuration page takes up too much vertical space. This is particularly true when a user is just getting started and there is only a single item in the list. This results in a large amount of white space. It also pushes the content that the user needs to configure down the page.

Let's change it to display a single item instead of multiple when the item is selected. We can offer a dropdown search box that allows users with 100s of configurations to filter them.

One option:
https://elastic.github.io/eui/#/forms/combo-box but limited to a single item

@mostlyjason mostlyjason added design Team:Fleet Team label for Observability Data Collection Fleet team labels Jul 22, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@mostlyjason mostlyjason changed the title [Ingest Manager] Change Agent configuration selection to combo box [Ingest Manager] Reduce height of Agent configuration selection box Jul 22, 2020
@mostlyjason
Copy link
Contributor Author

From Ron on Slack:

I see. EuiComboBox works for now 👍
If you agree it would be nice to have a regular dropdown with search, do you mind bringing the ask for search for SuperSelect to EUI?

@hbharding
Copy link
Contributor

Design update

Loom recording

image
image

We can change step 1 "Select an agent configuration" to use a EuiComboBox that only accepts 1 value. This component allows the user to search for configurations, and it supports custom renderings in the dropdown menu.

Some details to note:

  • This select box should be pre-populated with the Default agent configuration.
    • In the case that configurations can only have 1 instance of an integration (like Endpoint), we can't pre-select the default agent config if the integration already exists. We can show the agent configuration as disabled in the dropdown menu.
  • In the dropdown, I added the word "enrolled" to the agent count to clarify that these are agents enrolled with fleet (i.e. doesn't include standalone agents).
  • I moved the "create agent configuration" to the top right of the select input to reduce overall vertical height
  • I'm showing the # of enrolled agents as help text below the combo box. This # should change if the user selects a different config.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Fleet Team label for Observability Data Collection Fleet team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants