Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Lens] Remove inline eslint-disable-next-line exhaustive-deps #74090

Closed
7 tasks
mbondyra opened this issue Aug 3, 2020 · 2 comments
Closed
7 tasks

[Lens] Remove inline eslint-disable-next-line exhaustive-deps #74090

mbondyra opened this issue Aug 3, 2020 · 2 comments
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture

Comments

@mbondyra
Copy link
Contributor

mbondyra commented Aug 3, 2020 •
edited
Loading

As a result of resolving this issue: #49564, I opened this PR: #70010, that adds react-hooks/exhaustive-deps rule to lens globally, but disables the rule in some places inline. Once the PR is merged, we won't be able to produce more code that breaks the eslint rule, but we still need to clear the codebase from the inline exceptions. All the places are in these files:

  • x-pack/plugins/lens/public/editor_frame_service/editor_frame/suggestion_panel.tsx (1)
  • x-pack/plugins/lens/public/app_plugin/app.tsx (1)
  • x-pack/plugins/lens/public/editor_frame_service/editor_frame/editor_frame.tsx (4)
  • x-pack/plugins/lens/public/editor_frame_service/editor_frame/suggestion_panel.tsx (1)
  • x-pack/plugins/lens/public/loader.tsx (1)
  • x-pack/plugins/lens/public/editor_frame_service/editor_frame/workspace_panel/workspace_panel.tsx (2)
  • x-pack/plugins/lens/public/editor_frame_service/editor_frame/workspace_panel/chart_switch.tsx (1)
@mbondyra mbondyra added technical debt Improvement of the software architecture and operational architecture Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Aug 3, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@timroes timroes mentioned this issue Aug 6, 2020
Closed
6 tasks
@flash1293 flash1293 mentioned this issue Aug 14, 2020
Closed
43 tasks
@stratoula
Copy link
Contributor

This is done!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mbondyra @elasticmachine @stratoula