Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

index patterns scripted fields script type functionality needs removal #74118

Closed
mattkime opened this issue Aug 3, 2020 · 5 comments · Fixed by #92756
Closed

index patterns scripted fields script type functionality needs removal #74118

mattkime opened this issue Aug 3, 2020 · 5 comments · Fixed by #92756
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages technical debt Improvement of the software architecture and operational architecture

Comments

@mattkime
Copy link
Contributor

mattkime commented Aug 3, 2020

The index patterns scripted fields list has functionality to display the script type and to filter by script type. As of 7.0, there are only painless scripts. The code still needs to be cleaned up. I discovered the code via test/functional/apps/management/_scripted_fields_filter.js
@mattkime mattkime added technical debt Improvement of the software architecture and operational architecture Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages labels Aug 3, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@mattkime mattkime mentioned this issue Sep 28, 2020
Closed
63 tasks
@mattkime mattkime added Team:AppArch and removed Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Oct 2, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

@rashmivkulkarni
Copy link
Contributor

In the dropdown- there is painless and expression language. I do see it on master. Was able to pull down expression and create a script.
Screen Shot 2021-02-24 at 8 15 34 PM

@rashmivkulkarni rashmivkulkarni mentioned this issue Feb 25, 2021
Merged
@lukeelmers
Copy link
Member

@rashmivkulkarni I am not sure if the linked PR resolved this issue; IIRC, this issue exists to track the removal of the expression-based scripted fields.

(This is a breaking change that we intend to make in 8.0)

@lukeelmers
Copy link
Member

Although looking at this issue again, I think it might be a duplicate of #77669 so maybe it's okay to close anyway. WDYT @mattkime ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Feature:Data Views Data Views code and UI - index patterns before 8.0 Feature:Kibana Management Feature label for Data Views, Advanced Setting, Saved Object management pages technical debt Improvement of the software architecture and operational architecture
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Test fix management scripted field filter functional test and unskip it rashmivkulkarni/kibana
4 participants
@mattkime @lukeelmers @rashmivkulkarni @elasticmachine