Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Manager] Discuss dataset -> datastream / data_stream change #74257

Closed
4 tasks
skh opened this issue Aug 4, 2020 · 2 comments
Closed
4 tasks

[Ingest Manager] Discuss dataset -> datastream / data_stream change #74257

skh opened this issue Aug 4, 2020 · 2 comments
Assignees
Labels
discuss Team:Fleet Team label for Observability Data Collection Fleet team v7.9.0

Comments

@skh
Copy link
Contributor

skh commented Aug 4, 2020

This issue is to discuss what needs to be done if https://github.com/elastic/observability-dev/issues/1028#issuecomment-667909388 Option 2 is chosen for 7.9

  • Adjust dataset aggregation in data_stream handler to use datastream fields instead
    • Ensure all frontend code still works after that change
  • updating indices during package update used to use dataset before using the datastream api. it does still reference the index template dataset property to compose the stream name.
  • ...?
@skh skh added discuss Team:Fleet Team label for Observability Data Collection Fleet team labels Aug 4, 2020
@skh skh self-assigned this Aug 4, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@skh skh changed the title [Ingest Manager] Discuss dataset -> datastream change [Ingest Manager] Discuss dataset -> datastream / data_stream change Aug 4, 2020
@ruflin ruflin added the v7.9.0 label Aug 5, 2020
@jen-huang
Copy link
Contributor

Closing as the work in #74342 is merged. I couldn't think of any other areas that need changing to support this. Feel free to reopen if there is additional work needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss Team:Fleet Team label for Observability Data Collection Fleet team v7.9.0
Projects
None yet
Development

No branches or pull requests

4 participants