Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Only show fields with data in the filter bar #74492

Closed
flash1293 opened this issue Aug 6, 2020 · 4 comments
Closed

[Lens] Only show fields with data in the filter bar #74492

flash1293 opened this issue Aug 6, 2020 · 4 comments
Labels
enhancement New value added to drive a business result Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@flash1293
Copy link
Contributor

The index pattern objects provided by Lens to the query bar and filter bar include every field, which is not what Lens shows by default. They do not include data types Lens ignores such as scripted fields.

We could improve the filter creation UX by removing fields without data in the Lens app, but this might not work in the dashboard embeddable.

@flash1293 flash1293 added Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure labels Aug 6, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@flash1293 flash1293 added the enhancement New value added to drive a business result label Aug 6, 2020
@wylieconlon
Copy link
Contributor

wylieconlon commented Aug 6, 2020

I agree that this has the potential to be a better user experience, but it also has the potential to crash the filter bar. More work is needed to define a plan that works with these cases:

  • Lens doesn't include non-aggregatable fields in its index pattern, but these fields can be searched using both KQL and the filter manager
  • When opening Lens from a dashboard, will the filters from the dashboard render correctly?
  • Will this affect the indexpattern use by esaggs?

The dashboard embeddable is not an issue because we provide the ID of the index pattern, not a full object.

@flash1293
Copy link
Contributor Author

I only converted this to an issue (it was a card on the board before). I'm not sure whether we even should do this because it's inconsistent with the behavior of other apps.

I'm fine with closing this because it seems like this would require quite some coordination work to get right with little benefit.

@stratoula stratoula added the impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. label Jun 2, 2023
@stratoula
Copy link
Contributor

Thank you for contributing to this issue, however, we are closing this issue due to inactivity as part of a backlog grooming effort. If you believe this feature/bug should still be considered, please reopen with a comment.

@stratoula stratoula closed this as not planned Won't fix, can't repro, duplicate, stale Jan 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens impact:low Addressing this issue will have a low level of impact on the quality/strength of our product. Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants