Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[APM] Time spent by span type chart: Remove additional "No data" message since the expand/collapse toggle is not used #74834

Closed
formgeist opened this issue Aug 12, 2020 · 3 comments · Fixed by #75399
Assignees
Labels
enhancement New value added to drive a business result Team:APM All issues that need APM UI Team support v7.10.0

Comments

@formgeist
Copy link
Contributor

Summary

Since we moved the Transaction error rate chart into the Transactions page, we made the "Time spent by span type" chart follow the same size as the rest. This meant removing the option to expand/collapse the chart and always show the chart. Now when there's no data in the chart for various reasons, we show two empty state messages.

Solution

Remove the additional "No data within this time range." message by the title.

Screenshot 2020-08-12 at 10 31 07

@formgeist formgeist added Team:APM All issues that need APM UI Team support enhancement New value added to drive a business result labels Aug 12, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/apm-ui (Team:apm)

@cauemarcondes
Copy link
Contributor

@formgeist I removed the extra message, but still, I think we should show it the same way we show the other charts. WDYT?
Screenshot 2020-08-18 at 11 43 35

@formgeist
Copy link
Contributor Author

@cauemarcondes Yeah, makes sense to add the x-axis so it follows the rest.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Team:APM All issues that need APM UI Team support v7.10.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants