Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Add additional drag and drop states including "partially allowed" state #75938

Closed
wylieconlon opened this issue Aug 25, 2020 · 6 comments · Fixed by #78674
Closed

[Lens] Add additional drag and drop states including "partially allowed" state #75938

wylieconlon opened this issue Aug 25, 2020 · 6 comments · Fixed by #78674
Assignees
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@wylieconlon
Copy link
Contributor

wylieconlon commented Aug 25, 2020

Follow up to #75895

From @cchaos :

Since we're getting really reliant on indicating state and interaction through the visuals of the drag and drop elements, I've come up with a style guide.

Field item states

Empty

Filled

@wylieconlon wylieconlon added Team:Visualizations Visualization editors, elastic-charts and infrastructure Feature:Lens labels Aug 25, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@cchaos
Copy link
Contributor

cchaos commented Sep 2, 2020

I'm going to expand this particular issue to include updating the visual states for all interactions as well and I'll update the summary.

@cchaos cchaos changed the title [Lens] Updated cursor styles for drag interactions [Lens] Updated styles for drag interactions Sep 2, 2020
@wylieconlon wylieconlon changed the title [Lens] Updated styles for drag interactions [Lens] Add additional drag and drop states including "partially allowed" state Sep 8, 2020
@wylieconlon
Copy link
Contributor Author

@cchaos the style guide is looking very close, but I am not sure that we will be able to style the currently-dragged item. The main reason is that the drag cursor is converted to an image when the drag begins. There may be a workaround to this that I'm not aware of, but this is why we don't have special styles for the currently-dragged item right now.

@flash1293
Copy link
Contributor

As decided offline: Moving this out of 7.10 for now to focus on #54589 as it has a bigger user impact and we might not get to both

@cchaos
Copy link
Contributor

cchaos commented Sep 10, 2020

This is something I can try to take on for 7.10

@cchaos cchaos self-assigned this Sep 10, 2020
@flash1293
Copy link
Contributor

Cool, thanks a lot for your help, @cchaos !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants