Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Ingest Manager] When reinstalling a package, pipeline refs are not removed from saved object #76818

Closed
neptunian opened this issue Sep 4, 2020 · 3 comments · Fixed by #82078
Labels
bug Fixes for quality problems that affect the customer experience

Comments

@neptunian
Copy link
Contributor

neptunian commented Sep 4, 2020

When reinstalling, we add new pipelines to be installed to installed_es attributes of the saved object. If they are the same, as what is already installed (because of a reinstall) duplicates will exist because they have the same name, though duplicates of the actual elasticsearch pipeline asset will not exist. This could cause problems for each reinstall as a request to delete the same pipeline will be called for all the times it's been reinstalled. Realized this when doing a review: https://github.com/elastic/kibana/pull/74394/files#r483783627 . Can either not save dups in the first place or make sure the list of assets is unique. Or rethink how 'reinstall' works. Removing the whole package first, then installing it again, would also solve the problem.

A reinstall integration or unit test should be added to cover the case.

This is somewhat of an edgecase as users will not likely be reinstalling their packages.

@neptunian neptunian added bug Fixes for quality problems that affect the customer experience Team:Fleet Team label for Observability Data Collection Fleet team labels Sep 4, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/ingest-management (Team:Ingest Management)

@neptunian neptunian self-assigned this Oct 27, 2020
@neptunian neptunian removed the Team:Fleet Team label for Observability Data Collection Fleet team label Oct 28, 2020
@ph
Copy link
Contributor

ph commented Oct 29, 2020

@neptunian Is this still a valid issue?

@neptunian
Copy link
Contributor Author

@ph Yes, i just opened a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants