Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[UiActions][Drilldowns] Actions sorting in context menu #76923

Closed
Tracked by #71854
Dosant opened this issue Sep 8, 2020 · 1 comment · Fixed by #77162
Closed
Tracked by #71854

[UiActions][Drilldowns] Actions sorting in context menu #76923

Dosant opened this issue Sep 8, 2020 · 1 comment · Fixed by #77162
Assignees
Labels
bug Fixes for quality problems that affect the customer experience Feature:Drilldowns Embeddable panel Drilldowns Feature:UIActions UI actions. These are client side only, not related to the server side actions.. impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort regression v7.9.0

Comments

@Dosant
Copy link
Contributor

Dosant commented Sep 8, 2020

When attaching actions to a trigger there is no way to control actions ordering in context menu except relying on the order in which actions are attached. Relying on that we achived desired order in drilldown before:

Before ~7.9:

  1. Default "apply filter to current view" first
  2. Dynamic actions (Drilldowns) go after

image

After ~7.9:

We introduced nested triggers. So the actions in context menu aggregated from multiple triggers. In case of URL drilldown the order is not the one we'd want:

image

That's because when user clicks, there is VALUE_CLICK_TRIGGER which gets "Show on Github" action. Then there is APPLY_FILTER_TRIGGER triggered as nested trigger which finds "Apply filter on current view".

Part of: #71854

@Dosant Dosant added bug Fixes for quality problems that affect the customer experience regression loe:medium Medium Level of Effort Team:AppArch impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. Feature:UIActions UI actions. These are client side only, not related to the server side actions.. Feature:Drilldowns Embeddable panel Drilldowns v7.9.0 labels Sep 8, 2020
@Dosant Dosant self-assigned this Sep 8, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app-arch (Team:AppArch)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Fixes for quality problems that affect the customer experience Feature:Drilldowns Embeddable panel Drilldowns Feature:UIActions UI actions. These are client side only, not related to the server side actions.. impact:medium Addressing this issue will have a medium level of impact on the quality/strength of our product. loe:medium Medium Level of Effort regression v7.9.0
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants