Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Lens] Improve unclear UI for bucket aggregation grouping order #77015

Closed
6 tasks
mbondyra opened this issue Sep 9, 2020 · 2 comments
Closed
6 tasks

[Lens] Improve unclear UI for bucket aggregation grouping order #77015

mbondyra opened this issue Sep 9, 2020 · 2 comments
Assignees
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure

Comments

@mbondyra
Copy link
Contributor

mbondyra commented Sep 9, 2020

This issue is focused on finding a solution for the short term ("Lens by default" time frame). For a long-term solution covering more possible cases, see #79268

Right now, we have 3 different bucket aggregations (soon to be 4). It gives us 6 different combinations for 2 nested aggregations. Out of these six, the ones below influence the response that comes from ES meaningfully (not only order, but the data is different):

  • terms & terms
  • filters & terms
  • date & terms

The other three only change the order, which is important for pie or datatable vis:

  • filters & filters
  • date & filters
  • date & date

For the first three, it's easy to come up with a nice understandable copy we already have for BucketNestingEditor:
image

However, for the other three the copy doesn't seem helpful or correct (below):
image

We could add more information, like the label of the column to make it more understandable. However, this change only affects the order, so how about displaying the other design that we have implemented for BucketNestingEditor for more than 2 nested aggregations (not radios, but select list). I think it's actually more readable:
image
image

First step was implementing this PR: #77331, but we might want to revisit this issue.

@mbondyra mbondyra added good first issue low hanging fruit technical debt Improvement of the software architecture and operational architecture Feature:Lens Dependency:KibanaApp labels Sep 9, 2020
@wylieconlon wylieconlon added the Team:Visualizations Visualization editors, elastic-charts and infrastructure label Sep 9, 2020
@elasticmachine
Copy link
Contributor

Pinging @elastic/kibana-app (Team:KibanaApp)

@mbondyra mbondyra removed the good first issue low hanging fruit label Sep 10, 2020
@mbondyra mbondyra self-assigned this Sep 14, 2020
@flash1293 flash1293 added the loe:needs-research This issue requires some research before it can be worked on or estimated label Sep 30, 2020
@mbondyra mbondyra changed the title [Lens] Move BucketNestingEditor copy to operations [Lens] Improve unclear UI for bucket aggregation grouping order Oct 2, 2020
@flash1293 flash1293 added enhancement New value added to drive a business result and removed loe:needs-research This issue requires some research before it can be worked on or estimated technical debt Improvement of the software architecture and operational architecture labels Oct 2, 2020
@mbondyra
Copy link
Contributor Author

mbondyra commented Oct 7, 2020

I am closing this issue for now, we can reopen once we'll find time to implement better solution.

@mbondyra mbondyra closed this as completed Oct 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New value added to drive a business result Feature:Lens Team:Visualizations Visualization editors, elastic-charts and infrastructure
Projects
None yet
Development

No branches or pull requests

4 participants