[Lens] Remove leaking abstraction from field switch in PopoverEditor #77017
Labels
Feature:Lens
Team:Visualizations
Visualization editors, elastic-charts and infrastructure
technical debt
Improvement of the software architecture and operational architecture
To fix after merging #75635 and fieldless column.
The PopoverEditor
onClick
handler has a piece of logic that depends on specific operationTypes. I could move it to the columnDefinition, but it requires bigger refactoring because on the top of that it depends on compatible field type – and field is something we plan to remove as a required parameter of column. For that reason, I think it's best to tackle it once we get the fieldless column in placekibana/x-pack/plugins/lens/public/indexpattern_datasource/dimension_panel/popover_editor.tsx
Line 165 in 6e0b3f3
and later on:
if (incompatibleSelectedOperationType && !isTermsToFilters) {...}
The text was updated successfully, but these errors were encountered: